Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INCOMPATIBILITY] Custom LAN #29

Open
Sirmentio opened this issue Feb 20, 2023 · 6 comments
Open

[INCOMPATIBILITY] Custom LAN #29

Sirmentio opened this issue Feb 20, 2023 · 6 comments
Assignees
Labels
incompatibility Another mod is not compatible wontfix This will not be worked on

Comments

@Sirmentio
Copy link

Name of Mod
Custom LAN

Link to Mod Source
https://github.com/DimiDimit/Custom-LAN

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Windows 11
  • Minecraft Version 1.19.3
  • Ngrok-LAN Version 1.4.4

Additional context

@Sirmentio Sirmentio added the incompatibility Another mod is not compatible label Feb 20, 2023
@Flooflez
Copy link
Collaborator

I can see this being fixable, but I'm not exactly sure how.

This might take some time to fix because I'm a little busy at the moment and Custom LAN entirely overhauls how LAN worlds work.

Our mod just takes the Vanilla way and tunnels it with ngrok. I would have to define different behaviour when Custom LAN is being used. This will take some time to figure out how to make them compatible.

@slovinsqui
Copy link

please do, custom LAN is the only way I can use simple voice chat without buying a server

@DimiDimit
Copy link

Seeing as this mod reimplements a lot of Custom LAN's features, it'll probably be easier to just add ngrok support to Custom LAN…

For the time being, you could use the CLI (replace 25565 with your port):

ngrok tcp 25565

See also DimiDimit/Custom-LAN#28.

@Flooflez
Copy link
Collaborator

@DimiDimit You totally can go ahead if you wish, I don't really have the time to work on this project these days.

Here's the wrapper we're using, it's pretty simple to use. You can use this project for reference if needed/

@DimiDimit
Copy link

DimiDimit commented Oct 17, 2023

ngrok support has been added in Custom LAN 2.3.0, using the new Tunnel button on the Open to LAN screen!
As a bonus, you can start and stop the tunnel without restarting the LAN server and kicking all players out.

@Flooflez Flooflez added the wontfix This will not be worked on label Oct 17, 2023
@Flooflez
Copy link
Collaborator

@DimiDimit cool man, I've added a won'tfix tag to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibility Another mod is not compatible wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants