Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_elf32 incorrect number conversions #182

Open
pavelxdd opened this issue Mar 3, 2023 · 0 comments
Open

read_elf32 incorrect number conversions #182

pavelxdd opened this issue Mar 3, 2023 · 0 comments

Comments

@pavelxdd
Copy link

pavelxdd commented Mar 3, 2023

libappimage/src/libappimage/utils/ElfFile.cpp

Line 73 in 3467b20

last_section_end = file64_to_cpu(shdr32.sh_offset) + file64_to_cpu(shdr32.sh_size);

These are 32-bit fields, so file32_to_cpu should be used instead. I don't know if it changes the overall result, but I just noticed this while reading the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavelxdd