Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marine / terrestrial / biome field issues #464

Open
peggynewman opened this issue Jun 30, 2021 · 4 comments
Open

marine / terrestrial / biome field issues #464

peggynewman opened this issue Jun 30, 2021 · 4 comments
Labels
bug Something isn't working collection-community-testing enhancement New feature or request pipelines Issue related to pipelines

Comments

@peggynewman
Copy link

Feedback from OBIS - clearly there's a problem with this humpback whale record in the ocean:
https://biocache.ala.org.au/occurrences/71996a3f-60bc-4f34-b1cb-63f615503610

field value
Terrestrial true
Biome TERRESTRIAL
Marine false

It was agreed that we would implement biome using the GADM spatial layers (Confluence). Did Marine and Terrestrial come from GBIF? Should we plan to deprecate Biome in favour of the Marine and Terrestrial fields to avoid conflicting values?

@javier-molina javier-molina added the bug Something isn't working label Jul 1, 2021
@djtfmartin
Copy link
Member

Yes its accuracy issue, but perhaps not as bad on second glance when you zoom right in.

Screen Shot 2021-07-01 at 11 33 39 am

We are only using the Bitmap lookups for biome, we could also use shapefile intersects as well.

@djtfmartin
Copy link
Member

@peggynewman
The biocache-service is setting Marine and Terrestrial based on the biome value. biome is the only computed field in pipelines - Marine and Terrestrial don't exist in the AVRO.

@javier-molina
Copy link

Seems reasonable to me.

We are only using the Bitmap lookups for biome, we could also use shapefile intersects as well.

@djtfmartin djtfmartin changed the title marine / terrestrial / biome field issues marine / terrestrial / biome field issues Jul 8, 2021
@javier-molina javier-molina added enhancement New feature or request pipelines Issue related to pipelines labels Sep 16, 2021
@peggynewman
Copy link
Author

peggynewman commented Apr 28, 2022

This has been raised with us again. I'll take it over to the other repo and refer back to here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working collection-community-testing enhancement New feature or request pipelines Issue related to pipelines
Projects
None yet
Development

No branches or pull requests

3 participants