Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Accept Pandas Series in lov property #1444

Open
1 of 5 tasks
FlorianJacta opened this issue Jun 24, 2024 · 4 comments · May be fixed by #1447
Open
1 of 5 tasks

[Refactor] Accept Pandas Series in lov property #1444

FlorianJacta opened this issue Jun 24, 2024 · 4 comments · May be fixed by #1447
Labels
🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed

Comments

@FlorianJacta
Copy link
Member

Description

A user had an issue putting a Pandas Series as a Lov property, as it is not allowed. A better warning has been issued since the 3.1 release. Accepting a Pandas series as a potential value for the Lov property would be great.

from taipy.gui import Gui
import pandas as pd

data = pd.DataFrame({"Countries":["France", "Germany", "Italy", "Spain"],
                     "Population": [65, 83, 59, 47]})
selected = data["Countries"][0]
selection = data["Countries"]

page = "<|{selected}|selector|lov={selection}|dropdown|>"

Gui(page).run(port="auto")

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%.
  • Propagate any change on the demos and run all of them to ensure there is no breaking change.
  • Ensure any change is well documented.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@FlorianJacta FlorianJacta added 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 🟩 Priority: Low Low priority and doesn't need to be rushed labels Jun 24, 2024
@Satoshi-Sh
Copy link
Contributor

Can I take this issue?

@FlorianJacta
Copy link
Member Author

It has not been approved by R&D. @FredLL-Avaiga @FabienLelaquais what do you think?

@FredLL-Avaiga
Copy link
Member

I guess it makes sense

@FlorianJacta
Copy link
Member Author

Waiting for an answer from @FabienLelaquais

@Satoshi-Sh Satoshi-Sh linked a pull request Jun 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants