Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialTextBoxBorderBrush is wrong when switching out theme at runtime #348

Closed
1 task done
Mrxx99 opened this issue Feb 24, 2024 · 3 comments · Fixed by #349
Closed
1 task done

MaterialTextBoxBorderBrush is wrong when switching out theme at runtime #348

Mrxx99 opened this issue Feb 24, 2024 · 3 comments · Fixed by #349
Labels
bug Something isn't working

Comments

@Mrxx99
Copy link
Contributor

Mrxx99 commented Feb 24, 2024

Usage Information

3.4.0 / 11.0.9 / Windows 10

Description

Switching out the theme at runtime while also switching between light and dark will not update the MaterialTextBoxBorderBrush used e.g. in TextBox and ComboBox correctly leading to either a black brush on dark theme (which is barly visible) or a white brush on Light theme (which is completely invisible)

grafik

grafik

Reproduction Steps

A:

  1. check out the test repository https://github.com/Mrxx99/MaterialAvaloniaTest
  2. look at the textbox/combobox underline or the last border
  3. switch the theme with the toggle to dark
  4. look again at the textbox/combobox underline or the lasts border

B:

  1. Go to App.axaml and change BaseTheme to Dark
  2. look at the textbox/combobox underline or the lasts border
  3. switch the theme with the toggle to light
  4. look again at the textbox/combobox underline or the lasts border

Expected Behavior

Switchig between the light and dark theme updates the MaterialTextBoxBorderBrush correctly so e.g. TextBox or ComboBox are updated accoringly to the theme change

Actual Behavior

Brush is not updated correctly when switching themes, leading to barely visible to completely invisible lines in TextBox and ComboBox

Regression?

No response

Known Workarounds

No response

Anything else?

No response

Could you help with a pull-request?

No

Is there an existing issue for this?

  • I have searched the existing issues
@Mrxx99 Mrxx99 added the bug Something isn't working label Feb 24, 2024
@SKProCH
Copy link
Collaborator

SKProCH commented Feb 24, 2024

Yep, this is has been commented due to AvaloniaUI/Avalonia#12408

But since it has been resolved now I should return it back.

@SKProCH
Copy link
Collaborator

SKProCH commented Feb 25, 2024

Should be resolved in 3.4.1. Reopen issue if it persist,

@Mrxx99
Copy link
Contributor Author

Mrxx99 commented Feb 26, 2024

Thanks very much, issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants