Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce KustoRequest Object #345

Open
The-Funk opened this issue Jan 22, 2024 · 1 comment
Open

Introduce KustoRequest Object #345

The-Funk opened this issue Jan 22, 2024 · 1 comment

Comments

@The-Funk
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not related to a problem, but I'd like to ask for permission to implement a feature after PR #335 where a customer could pass a KustoQuery object (new work) which contains the properties utilized by the various execute methods in the Client interface and ClientImpl implementation.

In these methods each property is passed individually, the database name as a String, the ClientRequestProperties map, and the query as a String. However, in the implementation, each of the execute methods chain to a single actual implementation, wherein all 3 parameters are provided (or defaulted). I'd like to provide the option for new developers utilizing the library to use an object that encapsulates these required properties, and provides defaults where appropriate. This could help to reduce the surface of the library for new developers.

Describe the solution you'd like
KustoClient's additionally support a single KustoQuery object as a parameter, the creation of which would be the responsibility of the user of the library.

Describe alternatives you've considered
NA

Here's an example of what I'm thinking:

image

@ohadbitt
Copy link
Collaborator

ohadbitt commented Feb 5, 2024

Sure as long as its not exposed on the API ..
Next PR though

@The-Funk The-Funk changed the title Introduce KustoQuery Object Introduce KustoRequest Object May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants