Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use azure storage V10 to get async storage usage #69

Open
toshetah opened this issue Feb 11, 2019 · 2 comments
Open

Use azure storage V10 to get async storage usage #69

toshetah opened this issue Feb 11, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request ingest related to the ingestion module

Comments

@toshetah
Copy link
Contributor

toshetah commented Feb 11, 2019

This issue is with high importance.
We need to upgrade to storage client to V10 in order to get async operations.
The current implementation is not async.

In version 10 the Azure Storage Java SDK was separated into 2 sub-modules:

azure-storage-blob
azure-storage-queue

In order to use these modules, they must be added as dependencies to the ingest/pom.xml file, instead of the currently used azure-storage dependency: (Correct to the date of writing this comment)

<dependency>
    <groupId>com.microsoft.azure</groupId>
    <artifactId>azure-storage-blob</artifactId>
    <version>10.1.0</version>
</dependency>
<dependency>
    <groupId>com.microsoft.azure</groupId>
    <artifactId>azure-storage-queue</artifactId>
    <version>10.0.0-Preview</version>
</dependency>

Note that currently the azure-storage-queue is a preview version

Migrating to version 10 will require a substantial rewrite of any component that interfaces with Azure Storage.
Here is a list of the classes in the “ingest” module that are involved with the Azure Storage SDK: (correct to the date of writing this comment)

  • AzureStorageClient.java
  • IngestClientImpl.java
  • IngestionStatus.java
  • TableReportIngestionResult.java
  • IngestClientImplTest.java
  • AzureStorageClientTest.java
@toshetah toshetah added the ingest related to the ingestion module label Feb 11, 2019
@danield137 danield137 added the enhancement New feature or request label Jun 25, 2019
@ohadbitt
Copy link
Collaborator

Should be followed with performance comparison
Note that blob storage v8 does upload to blob blocks multithreaded

@ohadbitt
Copy link
Collaborator

#240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ingest related to the ingestion module
Projects
None yet
Development

No branches or pull requests

3 participants