-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart Add support for image pull secrets #3837
Comments
Can you expand on why you want this? Is it related to supply-chain security? Worried about the mcr image tag being maliciously updated? Or something else? Note: Might be worth seeing if other projects like CAPI support this. |
Hi Yes I would say supply chain security is correct. At the org I work for all AKS clusters are deployed to private VNets and the firewall restricts access to third party artifacts to use private registry only. So my cluster is not allowed to connect directly to mcr. Also many open source projects support imagePullSecrets. |
Describe the current behavior
A description of how things are today.
Today we can't use images that are stored in a virtual repository due to the lack of a input values for imagePullSecrets
Describe the improvement
How should things be changed or improved?
Need to add pull secrets input value on values.yaml file
Like this
Need to add the pull secrets to Deployment and Job templates under /spec/template/spec like below example:
Additional context
Add any other context about the suggested improvement.
Tasks
The text was updated successfully, but these errors were encountered: