Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection of missing version-specific extension implementations #3986

Open
theunrepentantgeek opened this issue May 2, 2024 · 0 comments
Open

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

Some of our extensions need to be implemented on every version of a resource, or none at all.

For example, the genruntime.Defaulter interface was implemented for API version 2021-05-15 of documentdb.SqlRoleAssignment and therefore should also have been implemented for API version 2023-11-15 when that was imported.

Failing to implement that lead to some hairy errors that required considerable debugging.

Describe the improvement

I'm wondering if we can write a convention-test that checks all our resources to verify that if one version implements genruntime.Defaulter, all versions do? Can we generalize this to other interface implementations?

@theunrepentantgeek theunrepentantgeek changed the title Detection of missing hand-written code Detection of missing version-specific extension implementations May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant