Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assigning illegal names when importing resources #4156

Open
theunrepentantgeek opened this issue Jul 9, 2024 · 2 comments
Open

Avoid assigning illegal names when importing resources #4156

theunrepentantgeek opened this issue Jul 9, 2024 · 2 comments
Assignees
Milestone

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

When doing an import from Azure, asoctl import azure-resource currently assigns the name of the Azure resource as the name of the Kubernetes cluster - but as reported in #4153 not all legal Azure names are legal Kubernetes names.

Describe the improvement

Sanitize the names to ensure they're Kubernetes compliant, filling in AzureName where required to maintain the name used in Azure.

Additional context

Ownership references need to be updated too.

@theunrepentantgeek theunrepentantgeek self-assigned this Jul 9, 2024
@theunrepentantgeek theunrepentantgeek added this to the v2.9.0 milestone Jul 9, 2024
@theunrepentantgeek
Copy link
Member Author

Should we consider lowercasing the cluster names as well?

@matthchr
Copy link
Member

Yeah because RFC1123 doesn't allow uppercase, so probably we should do a normalization pass that includes removal of characters that don't comply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants