Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sidecar container image configurable in Helm Chart #1335

Open
tafkam opened this issue May 2, 2024 · 0 comments
Open

Make sidecar container image configurable in Helm Chart #1335

tafkam opened this issue May 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tafkam
Copy link

tafkam commented May 2, 2024

Is your feature request related to a problem? Please describe.
Self-hosted container registries are a requirement in air-gapped environments. It seems that for the webhook-injected sidecar proxy container this is hardcoded in https://github.com/Azure/azure-workload-identity/blob/main/pkg/webhook/webhook.go#L27-L29 using the value from the makefile.

Describe the solution you'd like
Support changing the the sidecar proxy registry and image with values defined in the Helm chart. This could be achieved by using environment variables in the webhook itself.

Describe alternatives you've considered

Additional context

@tafkam tafkam added the enhancement New feature or request label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant