Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DevOps orchestratorPAT as KeyVault reference instead of supplied as a hardcoded string #65

Open
pareion opened this issue Dec 18, 2023 · 0 comments

Comments

@pareion
Copy link
Contributor

pareion commented Dec 18, 2023

Description

When creating the HelmRelease for the GitOps Connector and if you're using Azure DevOps, you have to supply an orchestratorPAT for the GitOps Connector to change the status of the deployment on the commits and for it to make a callback afterwards.

However, having the token in the code is a security issue, as everybody with access to the repository can now get the orchestratorPAT and potentially do anything that the token can do.

This could be secured by supplying a KeyVault reference with the secret name to the HelmRelease instead of providing the hardcoded token.

Optional: If you also use Workload Identity Federation you also need a service account. It would be extra swell if you could supply the service account along with the KeyVault and secret name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant