Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor Update Bug #3

Open
beardyFace opened this issue Apr 15, 2024 · 0 comments
Open

Actor Update Bug #3

beardyFace opened this issue Apr 15, 2024 · 0 comments

Comments

@beardyFace
Copy link

Should the actor update not utilise idx[0] and idx[1] for Q1 and Q2? currently it just gets the same value of Q from the same critic

---------------------------- update actor ----------------------------

    if step == self.G-1:

        actions_pred, log_prob, _ = self.actor_local.sample(states)             
        
        # TODO: make this variable for possible more than two critics
        Q1 = self.critics[idx[**0**]](states, actions_pred.squeeze(0)).cpu()
        Q2 = self.critics[idx[**0**]](states, actions_pred.squeeze(0)).cpu()
        Q = torch.min(Q1,Q2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant