Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer to peer code review #2

Open
brainconnect93 opened this issue Jun 16, 2022 · 1 comment
Open

peer to peer code review #2

brainconnect93 opened this issue Jun 16, 2022 · 1 comment

Comments

@brainconnect93
Copy link

Hi @basirking, Your work is well done and in accordance to the project requirements but i would like you to look into some of this changes
🪣 good GitHub workflow
🪣 No Linters
🪣 ES6 best practices

REQUIRED CHANGES ♻️

[OPTIONAL] on line 37 of your index.html kindly add a type with an attribute of submit to your button
https://github.com/basirking/Awsome-books-ES6/blob/fa605f3debb5c4695397d2a8e6005391b01ab0cc/index.html#L37

@Basir-Mohammadi
Copy link
Owner

Hi @brainconnect93 thank you so much for your review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants