Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit_mdp() should use the MDP parser #167

Open
orbeckst opened this issue Mar 2, 2019 · 1 comment
Open

edit_mdp() should use the MDP parser #167

orbeckst opened this issue Mar 2, 2019 · 1 comment

Comments

@orbeckst
Copy link
Member

orbeckst commented Mar 2, 2019

As pointed out in PR #164 , the edit_mdp() function should use the MDP parser.

This would also reduce extremely cryptic errors such as gmx grompp: -include is not an option, which happens when a custom template MDP file is used with gromacs.setup.MD() but the template does not contain an include = ... line, which edit_mdp() tries to replace but fails. The failed replacement is then interpreted as a commandline option for gromacs.grompp. Although that's pretty hacky/crappy code logic in the

def _setup_MD(dirname,
function, writing a better edit_mdp() (which could, for instance, insert variables as opposed to a simple search and replace, or could check if they are legal variables) would help.

@orbeckst
Copy link
Member Author

orbeckst commented Mar 2, 2019

For checking if input is legal: run gromacs.grompp() with an empty empty.mdp and then parse the resulting default mdout.mdp for all parameters that are legal with this version of Gromacs.

Actually, we should just create these lists for supported versions of Gromacs so that the function can also be used without gmx being available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant