Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to gpflow Naming #34

Open
BracketJohn opened this issue Jul 16, 2018 · 0 comments
Open

Transition to gpflow Naming #34

BracketJohn opened this issue Jul 16, 2018 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@BracketJohn
Copy link
Owner

Currently there is a kind of duality in the naming used internally:

gpflow has it's own naming scheme, which capitalizes kernel names. However they go as far as also using camel case (ArcCosine) and upper case (RBF). Currently this is then abstracted in kerndisc by the _kernels module, which maintains a dict of kernel_name.lower(): kernel_class mappings. This is useful for general coding, but also for grammar definition: The _grammar_duvenaud allows for kernels to be excluded from being a base_kernel. These can be passed by passing:

grammar_kwargs={'base_kernels_to_exclude': ['constant']}

as a parameter to discover. Here it is easier for a user to just use lower case kernel names, than remembering all the different casing options.

Whether this justifies deviation from gpflow is questionable though.

@BracketJohn BracketJohn added enhancement New feature or request question Further information is requested labels Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant