Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dialog interaction by removing the apply and cancel buttons #512

Open
thinkh opened this issue Feb 1, 2018 · 3 comments
Open

Unify dialog interaction by removing the apply and cancel buttons #512

thinkh opened this issue Feb 1, 2018 · 3 comments

Comments

@thinkh
Copy link
Member

thinkh commented Feb 1, 2018

At the moment the interaction of the dialogs differ a lot from each other. For instance, the change visualization dialog applies changes immediately, where as the mapping dialog applies a preview immediately, but the user has to choose between cancel, reset and apply. That is confusing and should be unified.

change visualization dialog

image

I suggest that we remove the apply and cancel button and apply the changes in all dialogs immediately. Only for some complex dialogs (e.g. the mapping dialog a reset button) is helpful to restore the initial state.

@sgratzl
Copy link

sgratzl commented Feb 1, 2018

some operations are expensive. including filtering and searching. So applying everything immediately when the user enters something can be costly.

@mstreit
Copy link
Member

mstreit commented Feb 1, 2018

but that does not change the fact that it is inconsistent at the moment. for instance, we already apply costly transformations (e.g., invert) immediately (sometimes even although there is a apply button). my feeling is that we should always apply actions immediately - even if it takes some time (it's usually below 1s though).

@thinkh
Copy link
Member Author

thinkh commented Feb 1, 2018

In addition to @mstreit comment: We can also show a spinner/loading icon while the change is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants