Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display preview instead of static icons for files with previews available #842

Open
FSM1 opened this issue Mar 24, 2021 · 4 comments
Open
Labels
Planning: Needs Design 🖼️ This UI component still needs one more designs to complete Product: Files

Comments

@FSM1
Copy link
Contributor

FSM1 commented Mar 24, 2021

No description provided.

@Tbaut
Copy link
Collaborator

Tbaut commented Mar 24, 2021

Do you think that would be for text files as well?

edit: @FSM1

@Tbaut Tbaut added the Planning: Needs Design 🖼️ This UI component still needs one more designs to complete label Jun 14, 2021
@Tbaut
Copy link
Collaborator

Tbaut commented Sep 20, 2021

The more I think about this, the less I think this is practicable

  • thumbnails for images hosted anywhere means we leak data
  • thumbnails generated on the client side on the fly means downloading all files which is def not practical.

did you have any other idea @FSM1

@FSM1
Copy link
Contributor Author

FSM1 commented Sep 20, 2021

  • thumbnails for images hosted anywhere means we leak data

The thumbnail images would be generated client-side, encrypted and uploaded to IPFS. When the UI sees a file system item that has a populated thumbnail field, the UI would request to load that specific thumbnail, decrypt and then render.

  • thumbnails generated on the client side on the fly means downloading all files which is def not practical.

Downloading and decrypting all the data would only be required if we would want all the previews to show up immediately. We could just as simply enable the generation of previews only for new uploads and when a file is previewed or downloaded.

@Tbaut
Copy link
Collaborator

Tbaut commented Sep 20, 2021

That'd be nice the way you describe it. This would require some more metadata stored per file on the api side given the current structure I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Planning: Needs Design 🖼️ This UI component still needs one more designs to complete Product: Files
Projects
None yet
Development

No branches or pull requests

2 participants