Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlink parameter types #185

Closed
odunbar opened this issue Aug 16, 2022 · 0 comments · Fixed by #186
Closed

Unlink parameter types #185

odunbar opened this issue Aug 16, 2022 · 0 comments · Fixed by #186
Assignees

Comments

@odunbar
Copy link
Collaborator

odunbar commented Aug 16, 2022

μ_c::FT,
σ_c::FT,
lower_bound::FT,
upper_bound::FT;

Simple cases can break when e.g., the four inputs are 0,1,-Inf,Inf which is viewed as Int64, Int64, Float64, Float64 (but above requires all arguments are the same type ::FT).

Possible solution

Replace with

mu_c::Real, 
sigma_c::Real,
lower_bound::Real,
upper_bound::Real

Note - this could be more pervasive than just the example I found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants