Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of covariance determinant #271

Closed
eviatarbach opened this issue Apr 5, 2023 · 1 comment · Fixed by #280
Closed

Remove use of covariance determinant #271

eviatarbach opened this issue Apr 5, 2023 · 1 comment · Fixed by #280

Comments

@eviatarbach
Copy link
Contributor

eviatarbach commented Apr 5, 2023

The covariance determinant is used several times in the package; namely, there is a warning issued if it decreases too much, and it is also used in find_ekp_stepsize to find a stepsize. The first use will be removed by #250, but the second one should also be removed in my view, since the determinant is not a sensible quantity when the covariance is rank deficient (number of parameters > number of ensemble members). Perhaps the trace could be used instead?

@eviatarbach
Copy link
Contributor Author

In discussion with @odunbar, we decided to remove find_ekp_stepsize altogether, in anticipation of the implementation of timestepping methods in #253.

@bors bors bot closed this as completed in 013469f May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants