Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive schedulers not compatible with particle failures #292

Closed
odunbar opened this issue Jun 8, 2023 · 0 comments · Fixed by #295
Closed

Adaptive schedulers not compatible with particle failures #292

odunbar opened this issue Jun 8, 2023 · 0 comments · Fixed by #295

Comments

@odunbar
Copy link
Collaborator

odunbar commented Jun 8, 2023

Currently schedulers meeting a NaN in the model evaluation will fail when calculating a timestep, even though we may be using a failure handler for the actual update. We should extend this behaviour to the schedulers too

The only current case is (if we are not doing IgnoreFailures) to call the "split_by_success(g)" and pass only the the successful particles into the timestep calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant