Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getfield of Main #354

Closed
simonbyrne opened this issue Nov 13, 2023 · 0 comments · Fixed by #355
Closed

getfield of Main #354

simonbyrne opened this issue Nov 13, 2023 · 0 comments · Fixed by #355

Comments

@simonbyrne
Copy link
Member

simonbyrne commented Nov 13, 2023

This isn't a good idea:
https://github.com/CliMA/EnsembleKalmanProcesses.jl/blob/4bcb401bfb0584f939a1c40cbf5b691951761f17/src/TOMLInterface.jl#L206C22-L207C12

Main is the top-level module, and we have no idea what is loaded there.

Possible fixes:

  • use Distributions instead of Main
  • if you're only supporting a few distrbutions, just define a dictionary.

cc @nefrathenrici

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant