Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETKI ignores timestepper #385

Closed
odunbar opened this issue Jun 26, 2024 · 0 comments · Fixed by #384
Closed

ETKI ignores timestepper #385

odunbar opened this issue Jun 26, 2024 · 0 comments · Fixed by #384

Comments

@odunbar
Copy link
Collaborator

odunbar commented Jun 26, 2024

Purpose

ETKI (and EKI) adapt to the timestep by dividing the noise covariance by the timestep

scaled_obs_noise_cov = ekp.obs_noise_cov / ekp.Δt[end]

unfortunately, unlike in EKI, ETKI does not use this quantity, instead it uses an internally stored inverse covariance.

Solution

Simply multiply the stored inverse covariance in etki_update by the timestep to pass this effect on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant