Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different model constructors for different common use cases #258

Closed
glwagner opened this issue May 31, 2019 · 1 comment
Closed

Different model constructors for different common use cases #258

glwagner opened this issue May 31, 2019 · 1 comment
Labels
feature 🌟 Something new and shiny science 🌊 Sometimes addictive, sometimes allergenic

Comments

@glwagner
Copy link
Member

As a convenience, we can provide constructors for different use cases. For example, we can have an OceanModel, which has ConstantAnisotropicDiffusivity as default and exposes the anisotropic coefficients directly to the user. This deals with @johncmarshall54's concern about the ConstantIsotropicDiffusivity default.

This will also help us move some of the body of the Model constructor into re-useable functions.
@glwagner glwagner added feature 🌟 Something new and shiny science 🌊 Sometimes addictive, sometimes allergenic labels May 31, 2019
@ali-ramadhan ali-ramadhan mentioned this issue Jun 20, 2019
Merged
@glwagner
Copy link
Member Author

This issue is redundant with #372.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature 🌟 Something new and shiny science 🌊 Sometimes addictive, sometimes allergenic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glwagner