Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tuples! #262

Closed
glwagner opened this issue Jun 2, 2019 · 2 comments
Closed

More tuples! #262

glwagner opened this issue Jun 2, 2019 · 2 comments
Labels
abstractions 🎨 Whatever that means cleanup 🧹 Paying off technical debt

Comments

@glwagner
Copy link
Member

glwagner commented Jun 2, 2019

Our function signatures are really long.

We need to use tuples / containers to pack arguments into Tuples or NamedTuples. Which groups make sense? The major ones I see are the source terms, the solution vector (u, v, w, T, S), and perhaps also parameters (eos, closure, constants, and g).

This may be helped by solving #163... but until then we can use tuples).

In addition @vchuravy suggested that we should pack the indices i, j, k into a tupled-index... perhaps I = (i, j, k) (or we can just use CartesianIndex).

For that, adding a convenience function to #249 to get the correct index associated with the intended ThreadsBlocksLayout for a given kernel might make sense.

@glwagner glwagner added abstractions 🎨 Whatever that means cleanup 🧹 Paying off technical debt labels Jun 2, 2019
@glwagner
Copy link
Member Author

Not sure if this helps with some of the issues discussed in #290, but it might.

@glwagner
Copy link
Member Author

Resolved bit-by-bit in many PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abstractions 🎨 Whatever that means cleanup 🧹 Paying off technical debt
Projects
None yet
Development

No branches or pull requests

1 participant