-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade TimeStepWizard to support model spinup? #356
Comments
Consider:
Because of these considerations I am not sure it makes sense to add |
These are good points. I'll close the issue. I hope you don't mind if I use your comments in the documentation under the adaptive time-stepping section. I ended up finding other ways to transition to turbulence in a stable manner using cfl(t) = min(0.005*t, 0.1)
wizard.cfl = cfl(model.clock.time) or changing the number of time steps between adaptive time steps with time. |
Yes, I’m happy to include general comments. We shouldn’t write too much on the topic. I think our advice will change when we have time stepping methods that are more appropriate for adaptive time stepping. |
Ultimately I think it’d be nice to build adaptive time stepping into the time step function itself, once we have time stepping methods that are well suited for it. |
@glwagner I'm thinking of upgrading the
TimeStepWizard
by adding aspinup_cfl
andspinup_time
to it, so it keepsCFL < spinup_cfl
whilemodel.clock.time < spinup_time
. So it would also need a pointer to the model clock.Does this make sense to you? Would be nice not to have to use two time-stepping loops.
The text was updated successfully, but these errors were encountered: