Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FT for "floating point type" #446

Closed
glwagner opened this issue Oct 7, 2019 · 1 comment · Fixed by #614
Closed

Use FT for "floating point type" #446

glwagner opened this issue Oct 7, 2019 · 1 comment · Fixed by #614
Labels
cleanup 🧹 Paying off technical debt

Comments

@glwagner
Copy link
Member

glwagner commented Oct 7, 2019 •
edited
Loading

In various parts of the code we use either T or FT to indicate the floating point type (eg, Float64 or Float32).

We should use FT consistently, as CLIMA will:

CliMA/ClimateMachine.jl#461
@glwagner glwagner changed the title Use DF for "floating point type" Use FT for "floating point type" Oct 8, 2019
@glwagner glwagner added the cleanup 🧹 Paying off technical debt label Oct 8, 2019
@ali-ramadhan
Copy link
Member

Hmmm, yeah I think T is still used in the Operators module. I'll make sure to use FT from now on, and we can close this when we've used FT everywhere.

@ali-ramadhan ali-ramadhan mentioned this issue Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Grids now have a topology CliMA/Oceananigans.jl
2 participants
@glwagner @ali-ramadhan