Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README is out of date #633

Closed
glwagner opened this issue Feb 18, 2020 · 1 comment · Fixed by #626
Closed

README is out of date #633

glwagner opened this issue Feb 18, 2020 · 1 comment · Fixed by #626
Labels
bug 🐞 Even a perfect program still has bugs documentation 📜 The sacred scrolls

Comments

@glwagner
Copy link
Member

The README example uses old syntax for time-stepping a model forward and I don't think will run with #master. It needs to be updated to use the Simulation type.
@ali-ramadhan ali-ramadhan added bug 🐞 Even a perfect program still has bugs documentation 📜 The sacred scrolls labels Feb 18, 2020
@ali-ramadhan
Copy link
Member

ali-ramadhan commented Feb 18, 2020 •
edited
Loading

This is fixed in #626

Sorry yeah I forgot to update the README in #621.

In general the README probably needs an update which is why I also opened #608

@ali-ramadhan ali-ramadhan mentioned this issue Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Even a perfect program still has bugs documentation 📜 The sacred scrolls
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Model to IncompressibleModel CliMA/Oceananigans.jl
2 participants
@glwagner @ali-ramadhan