-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU performance regression: tons of allocations #675
Labels
bug 🐞
Even a perfect program still has bugs
performance 🏍️
So we can get the wrong answer even faster
Comments
Looks like a couple of lines in julia> analyze_malloc(".")
305-element Array{CoverageTools.MallocInfo,1}:
⋮
CoverageTools.MallocInfo(1280, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 49)
CoverageTools.MallocInfo(1664, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 52)
CoverageTools.MallocInfo(1664, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 53)
CoverageTools.MallocInfo(1664, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 56)
CoverageTools.MallocInfo(1664, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 57)
CoverageTools.MallocInfo(2368, "./src/TimeSteppers/adams_bashforth.jl.18917.mem", 41)
CoverageTools.MallocInfo(4400, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 26)
CoverageTools.MallocInfo(4400, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 27)
CoverageTools.MallocInfo(4400, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 28)
CoverageTools.MallocInfo(4400, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 29)
CoverageTools.MallocInfo(4400, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 30)
CoverageTools.MallocInfo(4640, "./src/BoundaryConditions/apply_flux_bcs.jl.18917.mem", 17)
CoverageTools.MallocInfo(4640, "./src/BoundaryConditions/apply_flux_bcs.jl.18917.mem", 30)
CoverageTools.MallocInfo(5632, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 20)
CoverageTools.MallocInfo(9504, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 25)
CoverageTools.MallocInfo(24960, "./src/BoundaryConditions/fill_halo_regions.jl.18917.mem", 70)
CoverageTools.MallocInfo(35389680, "./src/BoundaryConditions/apply_flux_bcs.jl.18917.mem", 42)
CoverageTools.MallocInfo(35389680, "./src/BoundaryConditions/apply_flux_bcs.jl.18917.mem", 54) |
Hmmm so this regression happened somewhere between v0.22.0 and v0.23.0 so we just haven't been very careful... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐞
Even a perfect program still has bugs
performance 🏍️
So we can get the wrong answer even faster
Reported in PR #666. Might be serious enough that it is slowing down documentation building in PR #671.
The text was updated successfully, but these errors were encountered: