progress(simulation)
is not always called during run!
#723
Labels
duplicate 🧬
The search bar is your friend
progress(simulation)
is not always called during run!
#723
This line:
https://github.com/climate-machine/Oceananigans.jl/blob/6502f078c8f7698a2fb6cd398d9e96cfacccc787/src/Simulations.jl#L166
prevents the method
progress(simulation)
from being called ifprogress
is not a subtype of the abstract typeFunction
.This makes using callable objects for
progress
more complicated (at least, these callable objects would have to subtypeFunction
, which seems like an arbitrary requirement for such objects).What is the reasoning behind requiring
progress
to subtypeFunction
(and furthermore enforcing this with an if-statement)? Ifprogress
does not subtype function, the keyword argument is unused (despite the desperate efforts of flailing users, such as myself).Callable objects are nice for
progress
. For example, a callable object is a good way to keep track of wall time, make plots, automatically format strings containing diagnostics information, or otherwise reference objects outsidesimulation
for the purposes of logging.The text was updated successfully, but these errors were encountered: