Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Notification for Progress #76

Open
alfondehesa opened this issue Jan 12, 2024 · 6 comments
Open

Persistent Notification for Progress #76

alfondehesa opened this issue Jan 12, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@alfondehesa
Copy link

Not sure if this is the repo to add this in, or if this repo includes the app, but would be super cool to have a persistent notification with progress % and ETA instead of getting 20 notifications at each 5% at the most granular. I think Octoapp has an example of this for octoprint setups.

@Clon1998
Copy link
Owner

Hey,
I assume you are talking about persistent progress notifications on Android?

It is on my ToDo list, as this was one of the features that I sadly had to remove due to a change in a library. However, luckily the library finally supports these kinds of notifications again. I just have some other stuff to work on right now.

@Clon1998 Clon1998 added the enhancement New feature or request label Jan 12, 2024
@alfondehesa
Copy link
Author

Makes sense! Thanks for the quick reply.

@fuzelet
Copy link

fuzelet commented Feb 29, 2024

I can open an issue for this, but based on commits recently and my log file, it looks like this always making things a progress notification unless its a defined event like start, stop, error?

Is this intended behavior now and the % selection in the application doesn't control anything anymore?

image

e952712

Even if i set my App to use 5% it still seems to use the new notification type?
Screenshot 2024-02-28 210948

@Clon1998
Copy link
Owner

I can open an issue for this, but based on commits recently and my log file, it looks like this always making things a progress notification unless its a defined event like start, stop, error?

Is this intended behavior now and the % selection in the application doesn't control anything anymore?

image

e952712

Even if i set my App to use 5% it still seems to use the new notification type? Screenshot 2024-02-28 210948

Hey, are you using Android or IOS?
On Android, the Progress-Interval option has no effect anymore except if you disable it. While on IOS you should only get notifications in your defined progress interval

@fuzelet
Copy link

fuzelet commented Feb 29, 2024

Appreciate the information. I am using the android application from the play store in the "beta" sign up. I have noticed that I am also no longer get images with these new notifications as well. I seem to only get images when it's an event now, like start, end, error. Is that part of the new change as well?

Screenshot_20240229-074828
Screenshot_20240228-202937

@Clon1998
Copy link
Owner

Appreciate the information. I am using the android application from the play store in the "beta" sign up. I have noticed that I am also no longer get images with these new notifications as well. I seem to only get images when it's an event now, like start, end, error. Is that part of the new change as well?

Screenshot_20240229-074828 Screenshot_20240228-202937

That is a good point.
I might have forgotten to include the snapshots. I will verify if that is even possible. If it is possible I will make sure to update the companion. Otherwise, I will include an option to configure the notification type (Either persistent progress or the text-based)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants