Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

504: Gateway Timeout when trying to add .gitignore behind proxy #1

Closed
LaurentChardin opened this issue Jul 29, 2016 · 9 comments
Closed
Assignees
Milestone

Comments

@LaurentChardin
Copy link

The 'Add gitignore' command does not seem to work when behing a proxy : it generates a 504: Gateway Timeout error message.

The following environment variables http_proxy and https_proxy are set.
And VScode is respecting them since i could download the extension.

@CodeZombieCH
Copy link
Owner

CodeZombieCH commented Aug 24, 2016

Thank you for reporting this issue. I will take a closer look at this.

Resources:
http://code.visualstudio.com/docs/setup/setup-overview#_proxy-server-support

@CodeZombieCH
Copy link
Owner

I just asked the Visual Studio Code team what would be the recommended way to support proxy from an extension other than writing everything from scratch or copy&paste code from Visual Studio Code code base. As soon as I receive feedback I will post an update here and start with the implementation.

@ibigpapa
Copy link

I too am hitting this issue

@ibigpapa
Copy link

I think the proper way would be to pull the proxy information from the configurations. If i understand the documentation correctly the workspace.getconfig command actually pulls a merged Global config with settings in workspace config overwriting the globals.

Then i guess since code is available on github you might be able to extract the http request they use when it uses the proxy. I believe it's in the extensions code section.

@CodeZombieCH
Copy link
Owner

CodeZombieCH commented Nov 18, 2016

@ibigpapa: Thanks for your research. I came up with almost the same idea when I was looking for a solution. As the implementation is already part of Visual Studio Code, I asked them if they could expose the proxy settings through an API (see microsoft/vscode#12588). So far I have no information if the node package has been published.

As I have some time this weekend, I plan to implement proxy support this weekend by copy&paste the vscode implementation and publish it as version 0.5.0.

@CodeZombieCH CodeZombieCH added this to the v0.5.0 milestone Nov 18, 2016
@CodeZombieCH
Copy link
Owner

I just completed the proxy support implementation and tested it with a proxy set by Visual Studio Code settings.

@ibigpapa @LaurentChardin I would very much appreciate if you find some time installing the alpha version at the end of this comment and verify if this versions works with your proxy setup. Thanks a lot.

Alpha version: https://drive.google.com/open?id=0B6-NC49ru2VGMTdSYjZ2dV96STg

@jeedev0815
Copy link

I have tested the 0.50-alpha version and it works with my proxy settings!
I had previously also the problems as described by @ibigpapa .
Thanks!

@ibigpapa
Copy link

ibigpapa commented Dec 2, 2016

Tested on my system without a proxy and works just fine. Turned on the proxy and tested again and it still works 👍

@CodeZombieCH
Copy link
Owner

Thank you @jeedev0815 and @ibigpapa for the feedback. I will release the new version within the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants