Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Oracle/Sun compiler from CI tests? #595

Open
giacomofiorin opened this issue Sep 27, 2023 · 1 comment
Open

Drop Oracle/Sun compiler from CI tests? #595

giacomofiorin opened this issue Sep 27, 2023 · 1 comment

Comments

@giacomofiorin
Copy link
Member

Developer Studio is a commercial compiler that back in the day used to provide informative warning messages. However, it has a few caveats:

  • Restrictive license forces us to use secrets in CI; we're already doing that for NAMD and VMD, but the fewer the better.
  • Does not support anything more recent than C++11, and there seem to be no plans to change that.
  • The logic of its warnings about function hiding (one of its most useful IMO) starts getting a bit fragile when both virtual and override are used in the same class (even if not on the same function).

Open source tools like clang-tidy provide a useful alternative, especially if one fine-tunes their scope to avoid it being too aggressive.

Thoughts?

@jhenin
Copy link
Member

jhenin commented Sep 28, 2023

I see no problem with dropping it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants