Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: describe in emulated Reduce method that the result may be either x or x+p #1147

Closed
ivokub opened this issue May 29, 2024 · 0 comments · Fixed by #1224
Closed

bug: describe in emulated Reduce method that the result may be either x or x+p #1147

ivokub opened this issue May 29, 2024 · 0 comments · Fixed by #1224
Assignees
@ivokub
Labels
bug Something isn't working doc

Comments

@ivokub
Copy link
Collaborator

ivokub commented May 29, 2024

The behaviour is described in AssertIsInRange method documentation but not in Reduce method documentation. We also have to add a part to field.ToBits method to describe how to obtain binary decomposition of the canonical value of non-native element.
@ivokub ivokub added bug Something isn't working doc labels May 29, 2024
@ivokub ivokub self-assigned this May 29, 2024
@ivokub ivokub mentioned this issue Jul 24, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivokub ivokub

Labels
bug Something isn't working doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: strict ModReduce in emulated fields Consensys/gnark
1 participant
@ivokub