-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighting of inherited variables has very low contrast in dark themes #150
Comments
I agree++. I was looking for a way to change the color of dark blue semantic highlighting for inherited things to something more visible. The documents currently seem to say that the colors are set in stone: https://marketplace.visualstudio.com/items?itemName=tintinweb.solidity-visual-auditor " |
Fix: Change Inherited State Var color (you can also change other colors if you want):
For some reason there is no color on my inherited functions, which were also dark blue. (But I think this is a general bug with VSCode because inherited functions sometimes simply don't register properly). Find CSS colors here: https://www.w3.org/wiki/CSS/Properties/color/keywords |
@alexbabits great find! Will leave the issue open, so you can do a PR that changes the defaults if you want to :) |
Variables that are inherited from a base contract are shown in dark blue. This does not work well with dark themes (either default or the one that comes with the extension (see variable
eigenPodManager
):Default
![image](https://private-user-images.githubusercontent.com/46103853/313061842-a7131410-92ee-4920-abe3-02f2370a4c42.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2NTc0NDcsIm5iZiI6MTcyNTY1NzE0NywicGF0aCI6Ii80NjEwMzg1My8zMTMwNjE4NDItYTcxMzE0MTAtOTJlZS00OTIwLWFiZTMtMDJmMjM3MGE0YzQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDIxMTIyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM1ZGNlM2NhZjkxZGJjZDBlMTQ1ODA3MzRmMTU0ZjYxNDBjMzhhMGJkMzdmNzE3OTE2YjJiNDZiMDNiMDk0ZGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.I5-kLEN-hm5im7JXOQTHj-6Pv3sPqwlpy7iN1GWvbEs)
Dark Modern
:Solidity Visual Developer Dark
Definitely works slightly better on the second one, but both are straining to the eyes imo
The text was updated successfully, but these errors were encountered: