Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow devs to disable the colors by light/dark mode and instead let them decide which colors to use #20

Closed
earrietadev opened this issue May 31, 2024 · 21 comments
Labels
good first issue Good for newcomers ODHack

Comments

@earrietadev
Copy link
Contributor

No description provided.

@earrietadev earrietadev added the good first issue Good for newcomers label Jun 12, 2024
@No-bodyq
Copy link

Is this open for contribution??

@martinvibes
Copy link

@earrietadev i would like to contribute to this

@od-hunter
Copy link

od-hunter commented Jun 18, 2024

Is this open for contribution? If yes, please I'll love to be assigned this issue please. This is my first time contributing to Stellar and I will love to be given the opportunity to proof my skills. To solve this issue I will:

  1. Introduce a configuration option to disable light/dark mode colors.
  2. Allow developers to specify custom colors.
  3. Use TypeScript interfaces to ensure type safety.
  4. Update color handling logic to apply custom colors when configured.

I’ll submit a PR within 3-5 working days once I’m assigned.

Here is my Onlydust profile link https://app.onlydust.com/u/od-hunter , it might not look like it yet because I’m new to Onlydust, please give me the opportunity.

@nemealfaro
Copy link

Hi @earrietadev I would like to take this task. This would be my firts issue on this project.
I estimate no more than a 3 days for the changes to be ready.

@No-bodyq
Copy link

Hello, Can I get assigned to this??

@Josh-121
Copy link

Can I be assigned this?

@GreatJeremy
Copy link

I would love to contribute to this project.

@od-hunter
Copy link

Thank you 🙏🏾

@earrietadev
Copy link
Contributor Author

Is this open for contribution? If yes, please I'll love to be assigned this issue please. This is my first time contributing to Stellar and I will love to be given the opportunity to proof my skills. To solve this issue I will:

  1. Introduce a configuration option to disable light/dark mode colors.
  2. Allow developers to specify custom colors.
  3. Use TypeScript interfaces to ensure type safety.
  4. Update color handling logic to apply custom colors when configured.

I’ll submit a PR within 3-5 working days once I’m assigned.

Here is my Onlydust profile link https://app.onlydust.com/u/od-hunter , it might not look like it yet because I’m new to Onlydust, please give me the opportunity.

@od-hunter I just assigned this to you, you can ask question here. For the implementation keep in mind that the configuration needs to be "dead simple" so any the configuration needs to be at the creation level, something like this:

const kit: StellarWalletsKit = new StellarWalletsKit({
  network: WalletNetwork.TESTNET,
  selectedWalletId: XBULL_ID,
  modules: allowAllModules(),
  styles: {
    ...configuration_here
  }
})

Since is not going to change with the system mode, you also need to allow developers to update the color after it was created so it needs to have something like a function kit.updateStyles({ ...configuration_here })

@ktarun1419
Copy link

Hi i want to work on this issue @earrietadev

@od-hunter
Copy link

Hi i want to work on this issue @earrietadev

Sorry I’m working on it already. I’ll send my PR soon🙏🏾

@od-hunter
Copy link

Hello @earrietadev I’m still yet to hear from you

@earrietadev
Copy link
Contributor Author

@od-hunter I answered you a week ago: #23 (comment)

@od-hunter
Copy link

Hello @earrietadev sorry I didn’t know, can you please describe how I'm supposed to start the live server because it's not described in the package.json file. So sorry for the delay.

@ikemHood
Copy link
Contributor

ikemHood commented Jul 17, 2024

Hi @earrietadev I would love to work on this issue I know what needs to be done and I have done it already, if I’m been assigned I would create a PR for the work with a span of 24 hours

@od-hunter
Copy link

Hello @earrietadev please I’d not be able to continue this issue, kindly assign to someone else🙏🏾
Sorry for the inconveniences caused.

@od-hunter od-hunter removed their assignment Jul 22, 2024
@ikemHood
Copy link
Contributor

Hey @earrietadev Can I take on this now?

@earrietadev
Copy link
Contributor Author

Hi @ikemHood, thanks but I'm already doing it myself

@ikemHood
Copy link
Contributor

Too bad. i had already implemented it.

@earrietadev
Copy link
Contributor Author

@ikemHood you're always free to submit your pull request if you want

@earrietadev
Copy link
Contributor Author

Merged at #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ODHack
Projects
Development

No branches or pull requests

9 participants