-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow devs to disable the colors by light/dark mode and instead let them decide which colors to use #20
Comments
Is this open for contribution?? |
@earrietadev i would like to contribute to this |
Is this open for contribution? If yes, please I'll love to be assigned this issue please. This is my first time contributing to Stellar and I will love to be given the opportunity to proof my skills. To solve this issue I will:
I’ll submit a PR within 3-5 working days once I’m assigned. Here is my Onlydust profile link https://app.onlydust.com/u/od-hunter , it might not look like it yet because I’m new to Onlydust, please give me the opportunity. |
Hi @earrietadev I would like to take this task. This would be my firts issue on this project. |
Hello, Can I get assigned to this?? |
Can I be assigned this? |
I would love to contribute to this project. |
Thank you 🙏🏾 |
@od-hunter I just assigned this to you, you can ask question here. For the implementation keep in mind that the configuration needs to be "dead simple" so any the configuration needs to be at the creation level, something like this: const kit: StellarWalletsKit = new StellarWalletsKit({
network: WalletNetwork.TESTNET,
selectedWalletId: XBULL_ID,
modules: allowAllModules(),
styles: {
...configuration_here
}
}) Since is not going to change with the system mode, you also need to allow developers to update the color after it was created so it needs to have something like a function |
Hi i want to work on this issue @earrietadev |
Sorry I’m working on it already. I’ll send my PR soon🙏🏾 |
Hello @earrietadev I’m still yet to hear from you |
@od-hunter I answered you a week ago: #23 (comment) |
Hello @earrietadev sorry I didn’t know, can you please describe how I'm supposed to start the live server because it's not described in the package.json file. So sorry for the delay. |
Hi @earrietadev I would love to work on this issue I know what needs to be done and I have done it already, if I’m been assigned I would create a PR for the work with a span of 24 hours |
Hello @earrietadev please I’d not be able to continue this issue, kindly assign to someone else🙏🏾 |
Hey @earrietadev Can I take on this now? |
Hi @ikemHood, thanks but I'm already doing it myself |
Too bad. i had already implemented it. |
@ikemHood you're always free to submit your pull request if you want |
Merged at #33 |
No description provided.
The text was updated successfully, but these errors were encountered: