Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specific_ref_type is sometimes 16-bit rather than 32-bit #52

Open
ab9rf opened this issue Nov 13, 2023 · 5 comments
Open

specific_ref_type is sometimes 16-bit rather than 32-bit #52

ab9rf opened this issue Nov 13, 2023 · 5 comments

Comments

@ab9rf
Copy link
Member

ab9rf commented Nov 13, 2023

toady defines this as an enum without a specific base type so the underlying type is 32 bits, but he then does typedef int16_t Reference; and usually uses Reference so most of the time these are 16-bit values

we thus need to generate both a 16-bit and 32-bit version of this enum

@lethosor
Copy link
Member

Can't we just override base-type on fields where this is needed?

@lethosor
Copy link
Member

lethosor commented Jun 3, 2024

known issue DF-side that we have an existing solution for (overriding base-type at the field level)

@lethosor lethosor closed this as completed Jun 3, 2024
@ab9rf ab9rf transferred this issue from DFHack/df-structures Jun 3, 2024
@ab9rf ab9rf reopened this Jun 3, 2024
@ab9rf
Copy link
Member Author

ab9rf commented Jun 3, 2024

Reopening this as an issue for the ghidra importer

@lethosor
Copy link
Member

lethosor commented Jun 4, 2024

sorry, thought this was df-structures 🤦

@ab9rf
Copy link
Member Author

ab9rf commented Jun 4, 2024

sorry, thought this was df-structures 🤦

it was, i transferred the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants