Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim on_civzone_delete logic #4832

Open
myk002 opened this issue Aug 2, 2024 · 0 comments
Open

Trim on_civzone_delete logic #4832

myk002 opened this issue Aug 2, 2024 · 0 comments

Comments

@myk002
Copy link
Member

myk002 commented Aug 2, 2024

In the Buildings module, on_civzone_delete cleans civzone relationships before delete. DF now handles most of that itself, and we can remove some logic.

From Quietust on Discord:
Though I don't know how much of on_civzone_delete is actually necessary, since building_civzonest::removeUses cleans itself from all building.relations[] and also unassigns all units/items.
delete_civzone_squad_links and delete_assigned_unit_links are probably still necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant