Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/dry-buckets should set the plotinfo flag to trigger a bucket check #4854

Closed
ab9rf opened this issue Aug 11, 2024 · 2 comments · Fixed by DFHack/scripts#1294
Closed

fix/dry-buckets should set the plotinfo flag to trigger a bucket check #4854

ab9rf opened this issue Aug 11, 2024 · 2 comments · Fixed by DFHack/scripts#1294
Labels
good first issue Good for newcomers

Comments

@ab9rf
Copy link
Member

ab9rf commented Aug 11, 2024

there's a flag in plotinfo, eval_requester_can_check, that is used to indicate that a bucket may now be available to satisfy "give water" jobs and forces reevaluation of such activities at the next appropriate check. fix/dry-buckets should set this flag whenever it creates an empty bucket
@myk002
Copy link
Member

myk002 commented Aug 11, 2024 •
edited
Loading

note to implementer: we call the flag recheck_aid_requests

@myk002 myk002 added the good first issue Good for newcomers label Aug 11, 2024
@ab9rf
Copy link
Member Author

ab9rf commented Aug 11, 2024 •
edited
Loading

yeah sorry i was going based on ghidra there which was imported in april 2024 and hasn't been systematically updated for all the canonicalization work we've done since

@myk002 myk002 mentioned this issue Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
50.13-r5
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/dry-buckets: prompt DF to recheck aid requests when we empty a bucket myk002/scripts
2 participants
@myk002 @ab9rf