Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function signature changes not applied to the db #51

Open
Gericom opened this issue Aug 31, 2018 · 6 comments
Open

Function signature changes not applied to the db #51

Gericom opened this issue Aug 31, 2018 · 6 comments
Labels

Comments

@Gericom
Copy link

Gericom commented Aug 31, 2018

I noticed that when a change is made to the function signature (args or return type), either through the type declaration dialogue (Y key) or through the decompilers "rename lvar" on an argument, this change is saved to one of the xml files, but is not applied to any of the other users db's, leading to inconsistencies.

@bamiaux bamiaux added the bug label Aug 31, 2018
@bamiaux
Copy link
Contributor

bamiaux commented Aug 31, 2018

This is weird, I think there is a test on this. I'll check next week.
Is there any error message in the log file ?

@Gericom
Copy link
Author

Gericom commented Aug 31, 2018

I checked the log, but there don't seem to be any error messages, or anything suspicious in there.

@bamiaux
Copy link
Contributor

bamiaux commented Sep 3, 2018

Sorry, I have not been able to reproduce it.
I will push a patch tonight, containing a test checking changing one argument or the return type and it is correctly applied.
Maybe you can give me a way to reproduce it, or, ideal case, change my test to trigger your bug ?

@bamiaux
Copy link
Contributor

bamiaux commented Sep 14, 2018

@Gericom Your bug could have been from missing local type, which have been fixed in #49

@Gericom
Copy link
Author

Gericom commented Sep 14, 2018

I'll check later (when the new release comes out)

@bamiaux
Copy link
Contributor

bamiaux commented Sep 20, 2018

You can try https://github.com/DGA-MI-SSI/YaCo/releases/tag/v2.4
It won't sync changes from hexrays decompiler though, but changing the type with "Y" should work else it's a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants