-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pasting text while using markdownlint with a very large file can be slow (inconsistent, potential VS Code issue) #347
Comments
After reading other posts, it appears a profile is needed. I followed Profile the Running Extensions, reproduced the problem, and generated this file. |
To confirm: There is no delay for this scenario when you disable the markdownlint extension? The delay only happens when it is enabled? I'll look at the trace soon and acknowledge some opportunities to improve performance, but will also call out that your scenario file seems unusually large and seems like an outlier. Can you link to a copy of your file so I can try the scenario myself? |
Correct: When the markdownlint extension is disabled, there is no delay. Also, I have tried disabling all other extensions, leaving only markdownlint enabled, and the delay still occurs at least once out of every three paste attempts. I agree that the file size is an outlier. As a daily log, it will only continue to grow, and being able to lint it is a huge help in keeping it meaningful and searchable (I do appreciate this extension!). I can not provide the original file as sanitizing the PII would be time-consuming and risky, so I generated a similar file, which is attached. Using the generated file, I observe slowness while pasting text, although the time spent waiting on the spinner appears shorter (suggesting the issue is somehow content-related?). |
I've started looking at this. I see a delay maybe 1 of 5 times I paste that line. VS Code also gives me a lot of errors - even with
That's not a good sign and leads me to believe the problem won't be some slow parsing logic in |
I don’t think I’m going to be able to do much here. VS Code’s own telemetry suggests the slowdown is in its I disabled all event handlers except Here’s a typical example of normal/fast behavior:
And here’s an example of spinner/slow behavior (captured just a moment after the above):
Note that the time spent executing I’ll leave this issue open for now, but I don’t currently think it’s actionable by me. |
Thank you for looking into it and following up. I completely understand why it's not actionable. I appreciate your time. Do you have a "Buy Me A Coffee" or equivalent account? |
Hahaha, thanks, but you don't need to buy me a coffee for telling you I couldn't help. :) That said, if you are feeling especially generous, there should be a sponsor button on the GitHub project page that goes here: https://github.com/sponsors/DavidAnson |
Thank you for the donation!! |
Type: Bug
Observe a spinner appears while waiting for the paste to complete
(This is my first-ever bug report. VS Code opened this "Issue Reporter" that generated most of this content. I'm sorry if I missed any necessary details.)
Extension version: 0.55.0
VS Code version: Code 1.91.1 (f1e16e1e6214d7c44d078b1f0607b2388f29d729, 2024-07-09T22:06:49.809Z)
OS version: Windows_NT x64 10.0.22631
Modes:
System Info
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: