Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Difference between Design and Dev Dialog #115

Closed
felixbusadkt opened this issue Feb 6, 2023 · 1 comment · Fixed by #99
Closed

bug: Difference between Design and Dev Dialog #115

felixbusadkt opened this issue Feb 6, 2023 · 1 comment · Fixed by #99
Assignees
@corentin-stamper
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community
Milestone
0.3.0

Comments

@felixbusadkt
Copy link

Describe the bug
Dialog is different from the design propose by Vitamin :

  • There is no border radius
  • Actions or not side to side
  • Padding between action and bottom border is too wide

Steps to reproduce

Expected behavior
The dialog should be the same as that visible on Vitamin

Screenshots
https://www.figma.com/file/YLNocCTjGjcw6SiSRGoSu3/%F0%9F%91%8C-CISB-1567%3A-Design-Validation---Dialog?node-id=3328%3A7900

Device (please complete the following information):

  • Model: moto g(9) play
  • OS: Android
  • Version 10
@felixbusadkt felixbusadkt added the bug 🐛 Something isn't working label Feb 6, 2023
@ManonPolle ManonPolle transferred this issue from Decathlon/vitamin-android Feb 24, 2023
@ManonPolle
Copy link
Contributor

Figma has been updated with radius & elevation for modals, so we need to update Modal Component on vitamin-compose.

@Decathlon/design-system-core-team-design decathlon.design need to be updated as weel

@corentin-stamper corentin-stamper self-assigned this Feb 24, 2023
@corentin-stamper corentin-stamper mentioned this issue Feb 24, 2023
Merged
9 tasks
@ManonPolle ManonPolle added this to the 0.3.0 milestone Mar 16, 2023
@lauthieb lauthieb added community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community and removed run 💨 labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corentin-stamper corentin-stamper

Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

fix(modals): Buttons position corentin-stamper/vitamin-compose
4 participants
@lauthieb @corentin-stamper @ManonPolle @felixbusadkt