Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(modal): Actions buttons on modals are not well positionned #82

Closed
ManonPolle opened this issue Feb 1, 2023 · 0 comments · Fixed by #99
Closed

bug(modal): Actions buttons on modals are not well positionned #82

ManonPolle opened this issue Feb 1, 2023 · 0 comments · Fixed by #99
Assignees
@corentin-stamper
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community
Milestone
0.3.0

Comments

@ManonPolle
Copy link
Contributor

ManonPolle commented Feb 1, 2023 •
edited
Loading

Describe the bug
On modals, buttons are not aligned correctly.
Message

To Reproduce
1. Go to Sample app in Modal screen
2. Add a modal with 1 button

Expected behavior

  • the 1 or 2 right buttons are aligned on the right of the modal
  • the third left button is aligned on the left of the modal

image

Functional specs
image
@ManonPolle ManonPolle added bug 🐛 Something isn't working run 💨 labels Feb 1, 2023
@corentin-stamper corentin-stamper self-assigned this Feb 3, 2023
@corentin-stamper corentin-stamper mentioned this issue Feb 3, 2023
Merged
9 tasks
@ManonPolle ManonPolle added this to the 0.3.0 milestone Mar 16, 2023
@lauthieb lauthieb added community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community and removed run 💨 labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corentin-stamper corentin-stamper

Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

fix(modals): Buttons position corentin-stamper/vitamin-compose
3 participants
@lauthieb @corentin-stamper @ManonPolle