Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paddings on Card component aren't consistent #129

Closed
1 task done
MARIEDELATTRE opened this issue Dec 5, 2022 · 2 comments
Closed
1 task done

Paddings on Card component aren't consistent #129

MARIEDELATTRE opened this issue Dec 5, 2022 · 2 comments
Assignees
@MARIEDELATTRE
Labels
android 🟢 Related to android bug 🐛 Something isn't working components 🧩 Related to components dev issues created ✔️ Here to say that all developers issues had been created ios 🟡 Related to iOS web 🔵 Related to web

Comments

@MARIEDELATTRE
Copy link
Contributor

MARIEDELATTRE commented Dec 5, 2022 •
edited by lauthieb
Loading

Duplicates ❌

  • I have searched the existing issues

Which Figma library is concerned?

Vitamin Web UI Kit, Vitamin Android UI Kit, Vitamin iOS UI Kit

Current behavior 😯

On top image variant padding are 16 px.
On full image variant padding are 24 px.

Expected behavior 🤔

Paddings should be aligned even if it's different variants.

Context 🔦

No response

Screenshots / Videos 📸

No response

Tasks
Beta Give feedback
  1. bug(@vtmn/css-card): padding aren't consistent vitamin-web#1359
    CSS 🎨 bug 🐛 run 💨
    lauthieb
@MARIEDELATTRE MARIEDELATTRE added bug 🐛 Something isn't working android 🟢 Related to android ios 🟡 Related to iOS run 💨 labels Dec 5, 2022
@Sabrinavigil
Copy link
Contributor

Thanks @MARIEDELATTRE is it only on android ?

@MARIEDELATTRE MARIEDELATTRE added the web 🔵 Related to web label Dec 6, 2022
@MARIEDELATTRE
Copy link
Contributor Author

nope the 3 platforms

@MARIEDELATTRE MARIEDELATTRE self-assigned this Dec 23, 2022
@SimonLeclercq SimonLeclercq changed the title Padding on vitamin cards aren't consistent Padding on vitamin cards isn't consistent Dec 28, 2022
@lauthieb lauthieb changed the title Padding on vitamin cards isn't consistent Paddings on Card component aren't consistent Feb 6, 2023
@lauthieb lauthieb added the components 🧩 Related to components label Feb 6, 2023
This was referenced Feb 7, 2023
Open
Closed
Open
@lauthieb lauthieb added the dev issues created ✔️ Here to say that all developers issues had been created label Feb 7, 2023
@lauthieb lauthieb mentioned this issue Feb 7, 2023
Closed
@lauthieb lauthieb closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MARIEDELATTRE MARIEDELATTRE

Labels
android 🟢 Related to android bug 🐛 Something isn't working components 🧩 Related to components dev issues created ✔️ Here to say that all developers issues had been created ios 🟡 Related to iOS web 🔵 Related to web
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lauthieb @MARIEDELATTRE @Sabrinavigil