Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to convert all potential String.Format() calls to string interpolation #20

Open
DustinCampbell opened this issue Jul 21, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@DustinCampbell
Copy link
Owner

No description provided.

@DustinCampbell DustinCampbell self-assigned this Jul 21, 2015
@DustinCampbell DustinCampbell added this to the 1.0.3 milestone Jul 21, 2015
@Bryan-Legend
Copy link

As for providing a fix all option, that'll take a bit more design. This is implemented as a refactoring rather than a diagnostic/code fix pair, so the "FixAllProvider" APIs aren't available. I chose to implement this as a refactoring because this operation struck me as something that you might not always want to do. So, it seemed a bit invasive to squiggle every potential String.Format() call that could be converted to string interpolation.

You are absolutely right, there should never be squiggles on all the String.Format calls. But I would still like the the convert all options to be available when I want them. Same with "Use Expression-Bodied Member", I'd like convert all available but hate all the messages. The FixAll options should be available independent of the warning level. Seems like a change to VS is needed.

@DustinCampbell DustinCampbell modified the milestones: 1.0.4, 1.0.3 Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants