Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ubuntu version in deploy process #123

Open
1 task done
the-mzakrzewski opened this issue Jul 14, 2024 · 2 comments
Open
1 task done

[BUG] Ubuntu version in deploy process #123

the-mzakrzewski opened this issue Jul 14, 2024 · 2 comments
Labels
bug Something isn't working 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)

Comments

@the-mzakrzewski
Copy link
Contributor

the-mzakrzewski commented Jul 14, 2024

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

Reviewing the repo

Version of CreatorsRegistry (for example "v0.19.0")

0.26.2

Description

I've noticed that the pipeline uses 'ubuntu-latest' when deploying, which can cause errors when the Ubuntu version changes.

It is safer to specify the specific system version you want to use.

Steps to Reproduce

Check the files in a directory: https://github.com/EddieHubCommunity/CreatorsRegistry/tree/main/.github/workflows

Screenshots

No response

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

I would change the Ubuntu version to use the latest LTS.

@the-mzakrzewski the-mzakrzewski added bug Something isn't working 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jul 14, 2024
@eddiejaoude
Copy link
Member

Thanks for raising. The url provided doesn't work.

I am torn on this topic, because fixing it is better, but it often gets left behind also which creates other problems also.

@the-mzakrzewski
Copy link
Contributor Author

URL fixed, don't worry, I just put information about what I found in my opinion. We can come back to this problem later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)
Projects
None yet
Development

No branches or pull requests

2 participants