Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request and suggestion #1

Open
despecial opened this issue Jan 24, 2021 · 4 comments
Open

request and suggestion #1

despecial opened this issue Jan 24, 2021 · 4 comments
Assignees

Comments

@despecial
Copy link

First up: thanks for bringing back that extension!

One little suggestion:

  • move it to the "formatting" extension list (see Dashboard in Flarum beta15)

Requests:

  • could you add the following buttons to the editor
    -- spoiler
    -- strikethrough
@Cadiducho
Copy link
Collaborator

Hi there! Glad to see someone more is using this.
I've just done the little suggestion. You can update to 1.0.1 version and the extension will be shown in the correct category

About the request: I take note about it, but i'll take several days (or weeks), because I dont have as many time as I wish at the moment

@Cadiducho Cadiducho self-assigned this Jan 24, 2021
@despecial
Copy link
Author

Sure, we love the spoiler function and missed it when it was abandoned.

There was a code snippet for adding Shortcut Buttons to the markdown editor but I was unable to add them.
Take a look here https://github.com/Veriael/markdown/blob/53c55620626d9ee31d48841bfeaba137fa4f9b96/js/src/forum/index.js#L45

Git: https://github.com/Veriael/markdown
Flarum: https://discuss.flarum.org/d/21412-flarum-markdown-fork-with-missing-options

@Cadiducho
Copy link
Collaborator

I've been triying to insert the new two buttons to the toolbar from Flarum Markdown, but it seems imposible since Flarum do not export their core-extensions components to the public, in other words, I just can't import their MarkdownToolbar component and modify or extend it (its a pitty)

I had thought to publish the update to Beta 16 along the button feature, but at the moment I'll keep it while I found another solution that do not imply copy-paste all Flarum internal components into my code just to add two buttons

@despecial
Copy link
Author

:( okay, weird. Maybe we need to get in contact with the Flarum developers and check if it will be possible somehow. Thanks for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants