Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a KeyboardKeySet class #49

Open
romadanskiy opened this issue May 29, 2024 · 0 comments · May be fixed by #51
Open

Create a KeyboardKeySet class #49

romadanskiy opened this issue May 29, 2024 · 0 comments · May be fixed by #51
Assignees
Labels
enhancement New feature or request

Comments

@romadanskiy
Copy link
Contributor

There is code duplication in the project with the definition of sets of keyboard keys (for example, a collection of numpad buttons for NumpadListener class and for tests NumpadListenerSubscribeTests and NumpadListenerUnsubscribeTests).

The proposed solution is to make a KeyboardKeySet class that will provide collections of specific keyboard keys (numpad keys, number keys, function keys, etc.).

Advantages:

  • Reduce code duplication.
  • Allows users to use ready-made key sets to create their own logic.

Proposed key sets:

  • Numpad keys
  • Number keys (including numpad keys)
  • Function keys (F1, F2, ...)
  • Arrow keys
  • Navigation keys (Home, End, Page Up, Page Down)
  • Multimedia keys (Play/Pause, Stop, Previous Track, Next Track, Volume Up, Volume Down, Mute)
  • Editing keys (Backspace, Enter, Caps Lock, Insert, Delete)
  • Special keys (Control, Alt, Fn, Tab, Esc)
@Empiree Empiree added the enhancement New feature or request label May 29, 2024
@romadanskiy romadanskiy linked a pull request Jun 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants