We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vid_scheme
u32
usize
Currently vid_scheme starts like this:
HotShot/crates/types/src/vid.rs
Lines 78 to 83 in e0f9600
The arg num_storage_nodes should be of type u32 instead. That would eliminate the error handling cruft. It would also make life easier for downstream users, who need to convert a u32 to usize anyway: https://github.com/EspressoSystems/espresso-sequencer/blob/26a6b299ce260a210e6fa3253bbd50fb57f3023d/sequencer/src/block/full_payload/ns_proof.rs#L47-L51
num_storage_nodes
Dead easy.
No response
vid_scheme takes a u32 instead of usize
The text was updated successfully, but these errors were encountered:
ggutoski
shenkeyao
No branches or pull requests
What is this task and why do we need to work on it?
Currently
vid_scheme
starts like this:HotShot/crates/types/src/vid.rs
Lines 78 to 83 in e0f9600
The arg
num_storage_nodes
should be of typeu32
instead. That would eliminate the error handling cruft. It would also make life easier for downstream users, who need to convert au32
tousize
anyway:https://github.com/EspressoSystems/espresso-sequencer/blob/26a6b299ce260a210e6fa3253bbd50fb57f3023d/sequencer/src/block/full_payload/ns_proof.rs#L47-L51
What work will need to be done to complete this task?
Dead easy.
Are there any other details to include?
No response
What are the acceptance criteria to close this issue?
vid_scheme
takes au32
instead ofusize
Branch work will be merged to (if not the default branch)
No response
The text was updated successfully, but these errors were encountered: