Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Byzantine testing] - Fix the twins byzantine implementation #3441

Open
ss-es opened this issue Jul 12, 2024 · 1 comment
Open

[Byzantine testing] - Fix the twins byzantine implementation #3441

ss-es opened this issue Jul 12, 2024 · 1 comment

Comments

@ss-es
Copy link
Contributor

ss-es commented Jul 12, 2024

What is this task and why do we need to work on it?

Behaviour::ByzantineTwins does not seem to behave as expected with DoubleTwinsHandler (which we expect should function similarly to DoubleProposeVote). The most likely causes are either issues with sharing consensus state (unlikely) or wiring issues with the spawned loops that connect each set of consensus tasks to the network task.

What work will need to be done to complete this task?

No response

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

An integration test with a node using DoubleTwinsHandler passes.

Branch work will be merged to (if not the default branch)

No response

@shamb0
Copy link
Contributor

shamb0 commented Aug 13, 2024

Hi @ss-es, Could you please assign & guide me on this Task, I am interested to pick it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants